RFR: vcs: make RepositoryTests deterministic

Robin Westberg rwestberg at openjdk.java.net
Tue Mar 16 10:01:42 UTC 2021

On Tue, 16 Mar 2021 09:57:44 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this small patch to make the test `RepositoryTests.testCommitMetadataWithBranchesWithGit` deterministic. The problem is that different versions of `git` can traverse the commit graph differently and the resulting list from the call to `commitMetadataFor` might therefore contain commits in an unknown order. The test should therefore not assume that the commits are ordered in a particular way, but instead ensure that the list contains only the expected commits.
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1061

More information about the skara-dev mailing list