RFR: Really fix so tests ignore .gitconfig
ehelin at openjdk.java.net
Wed Mar 17 09:20:41 UTC 2021
On Tue, 16 Mar 2021 14:08:02 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> It turned out that [SKARA-913](https://bugs.openjdk.java.net/browse/SKARA-913) which fixed unwanted side effects of [SKARA-868](https://bugs.openjdk.java.net/browse/SKARA-868), in fact broke Skara testing completely the way SKARA-868 was supposed to fix. In SKARA-913 only a few of the Skara tests were properly configured to really ignore the local configuration; something I discovered lately when running all tests on a machine with a .gitconfig that foils several git tests from running.
> Since there is no really single point of entry to say to the Repository logic "I am now running a test", I have created a wrapper TestableRepository.init(), which calls Repository.init() and makes sure ignoreConfiguration is on.
> At least this solves the problem for me. There might be other tests hiding where other strange configurations provoke a failure; I know of no systematic way to find all these, so I'll guess we have to fix that when it is discovered.
Marked as reviewed by ehelin (Reviewer).
More information about the skara-dev