[cr] RFR: 658: Webrev frame view does not have an indication of the current file

Robin Westberg rwestberg at openjdk.java.net
Wed Mar 31 08:36:39 UTC 2021

On Tue, 30 Mar 2021 13:26:38 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that makes the fragment (the part in the URL after the `#`) include the filename, not only the view and file number. This makes it easier in particularly the "Frames" view to see the filename of the file being changed (although browsers like Safari and Chrome nowadays hide parts of the URL by default). This also makes webrev.js more similar to the old webrev.ksh which included the filename in almost all URLs.
> Testing:
> - Local testing using Firefox on Linux x64
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/cr/pull/5

More information about the skara-dev mailing list