RFR: forge: GitLab members endpoint return 404 for non-members

Robin Westberg rwestberg at openjdk.java.net
Wed Mar 31 12:28:35 UTC 2021

On Wed, 31 Mar 2021 12:25:14 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that fixes how `GitLabRepository.canPush` uses the `members` REST endpoint. Turns out that the `members` endpoint returns a `404` if the user is _not_ a member of the project (not documented of course �� ).
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1106

More information about the skara-dev mailing list