RFR: 1052: Memory leak in RestRequestCache

Erik Helin ehelin at openjdk.java.net
Wed May 26 07:45:00 UTC 2021

On Tue, 25 May 2021 23:09:20 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> This patch adds a regularly scheduled cache eviction call to the RestRequestCache.
> bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java line 328:
>> 326:     Duration cacheEvictionInterval() {
>> 327:         if (!config.contains("runner") || !config.get("runner").contains("cache_eviction_interval")) {
>> 328:             var defaultValue = Duration.ofMinutes(5);
> Have you done any testing to see if a default interval of 5 minutes is the right frequency for cache evictions? Naively, it seems like it might be too often. Is there a performance impact?

I agree with Kevin, I _think_ we could probably keep at least 60 minutes of cache, if not even more. Or I might have missed something ����


PR: https://git.openjdk.java.net/skara/pull/1167

More information about the skara-dev mailing list