RFR: 1053: Github check in conclusion "stale" not handled

Erik Helin ehelin at openjdk.java.net
Thu May 27 09:09:50 UTC 2021

On Wed, 26 May 2021 20:15:15 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch adds handling of the "stale" github check result. A stale result does not have a completed_at time, so we need to handle that this field can be null.
> I tried to look through the code to see if there were any places where we would need to react to this new result, but could only find one that seemed relevant.

Looks good!

forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java line 410:

> 408:                             if (completed) {
> 409:                                 var conclusion = c.get("conclusion").asString();
> 410:                                 String completedAtString = c.get("completed_at").asString();


                                var completedAtString = c.get("completed_at").asString();


Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1172

More information about the skara-dev mailing list