RFR: bot: add performance metrics for work items

openjdk-notifier [bot] "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net
Fri May 28 08:22:52 UTC 2021

On Wed, 26 May 2021 13:51:02 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that adds runtime performance metrics for work items. I have added three new gauges:
> - `skara_runner_cpu_time`
> - `skara_runner_user_time`
> - `skara_runner_allocated_bytes`
> All three are per work item and make use of the `ThreadMXBean` to set the gauges. We can use the methods in `ThreadMXBean` because the `Runnable` that is running on a thread in the thread pool cannot be preempted or moved to another thread, i.e. it will have the same "carrier" thread for its whole execution.
> Testing:
> - [x] Manual testing on Linux x64 using the mirror bot
> Thanks,
> Erik

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout counter-exception-type
git fetch https://git.openjdk.java.net/skara master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push


PR: https://git.openjdk.java.net/skara/pull/1171

More information about the skara-dev mailing list