Integrated: 1148: Emails on mailing lists are not posted to GitHub PR

Erik Joelsson erikj at
Wed Sep 1 14:06:11 UTC 2021

On Tue, 31 Aug 2021 19:06:29 GMT, Erik Joelsson <erikj at> wrote:

> For a bit over a month, the mlbridge bot seems to be having trouble posting emails as comments in PRs. Especially the hotspot-dev list has been experiencing this. This patch should fix that problem.
> The reading of the mailing list archives happens in MailmanListReader::conversations. There we loop over mailing lists and months. If a particular archive file (combo of mailing list and month) does not exist, the inner loop breaks. This break is the bug. In our case, the mailing list ide-support-dev does not have any emails for August and (I think because of that) the URL returns 404. This is triggering the break, which is stopping the inner loop (which loops over mailing lists) so it never gets to hotspot-dev (and a few others).
> Looking at the history, this broke in SKARA-843, where the inner loop was added. The break statements then started acting on the wrong loop.
> I'm also improving some log messages which I needed while debugging this.

This pull request has now been integrated.

Changeset: 59c46b88
Author:    Erik Joelsson <erikj at>
Stats:     16 lines in 3 files changed: 0 ins; 3 del; 13 mod

1148: Emails on mailing lists are not posted to GitHub PR

Reviewed-by: kcr



More information about the skara-dev mailing list