<Sound Dev> code review request: 7087428: move client tests out of jdk_misc
kelly.ohair at oracle.com
Wed Sep 7 08:39:02 PDT 2011
Looks great. Thanks for taking care of this.
On Sep 6, 2011, at 7:27 PM, Weijun Wang wrote:
> root: http://cr.openjdk.java.net/~weijun/7087428/control/webrev.00/
> jdk: http://cr.openjdk.java.net/~weijun/7087428/webrev.01/
> I also update Makefile to put jdk_sound to its correct alphabetical position.
> On 09/07/2011 02:30 AM, Kelly O'Hair wrote:
>> Looks fine.
>> But the files make/jprt.properties in both the root repository and the jdk repository
>> will minor changes to add jdk_sound as a new test for JPRT.
>> You can place it in the jprt.make.rule.all.test.targets list.
>> On Sep 6, 2011, at 8:12 AM, Weijun Wang wrote:
>>> Hi Kelly
>>> Webrev at http://cr.openjdk.java.net/~weijun/7087428/webrev.00/
>>> Basically I'd like jdk_misc batch to contain only "headless" tests and move all the others into their own batch.
>>> 1. Move javax/imageio, javax/print, sun/pisces to jdk_awt
>>> 2. Move com/sun/java/swing to jdk_swing
>>> 3. Move com/sun/org/apache/xml/internal/security to jdk_security3
>>> 4. Create a separate batch jdk_sound for javax/sound
>>> 5. Divide demo to different parts and move demo/jfc to jdk_swing. If the demo dir is moved to some other directory later, more updates will be needed.
>>> Please note that I change com/sun/java to com/sun/java/swing, and com/sun/org to com/sun/org/apache/xml/internal/security, since those are the only sub-dir there. There might be other sub-dirs later.
>>> -------- Original Message --------
>>> 7087428: move client tests out of jdk_misc
>>> === *Description* ============================================================
>>> The jdk_misc batch in test/Makefile contains tests for swing, sound etc, They should be moved to their own batches.
More information about the sound-dev