<Sound Dev>  Request for review: 7058662 7058666 7058672
Sergey.Bylokhov at oracle.com
Tue Oct 1 05:09:18 PDT 2013
Thanks for review!
Here is updated version of the fix.
On 01.10.2013 0:57, Florian Bomers wrote:
> Hi Sergey,
> I ("$$fb") took the liberty to review :)
> in AiffFileReader.java, you've changed
>> int channels = dis.readShort();
>> short channels = dis.readShort();
> As these fields are unsigned, you should rather use this:
> int channels = dis.readUnsignedShort();
> same for "short sampleSizeInBits".
> The rest looks fine to me.
> On 27.09.2013 14:55, Sergey Bylokhov wrote:
>> Does anybody have a time for review?
>> On 20.09.2013 18:56, Sergey Bylokhov wrote:
>>> Please review the fix for jdk 8.
>>> Input validation was added to the numbers of channels and
>>> sampleSizeInBits. So now we throw UnsupportedAudioFileException
>>> instead of ArithmeticException.
>>> Hangs will be fixed as part of 7058700.
>>> Webrev can be found at:
Best regards, Sergey.
More information about the sound-dev