<Sound Dev> [9] Review Request: 8013586 and 8130305

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Jul 21 15:17:01 UTC 2015

Please review the fix for jdk9. Two issues were fixed:
8013586: audioInputStream.close() does not release the resource
8130305: AudioSystem behavior depends on order that providers are located

  - Streams were not closed when necessary(ex: WaveFloatFileReader. 
getAudioInputStream(File)). In the fix they are closed always in case of 
any exceptions.
  - Some of the readers do not reset the streams when they throw an 
UnsupportedAudioFileException exception.
  - Some of the readers(like AiffFileReader) do not wrap 
(FileInputStream, etc) in BufferedInputStream.

In the fix I merge all implementations of getAudioXXX to the SunFileReader.

Note that I added a comment to the 
SunFileReader.getAudioFileFormat(InputStream) that implementation 
contradicts the specification, and it seems the javadoc should be 
updated? And I created a new issue about EOFException: 

Also I have a related question about WaveExtensibleFileReader why it was 
not added to the spi.AudioFileReader? Because of this 
WaveExtensibleFileReader actually is never used. Is that intentionally?

Bug: https://bugs.openjdk.java.net/browse/JDK-8013586
Webrev can be found at: http://cr.openjdk.java.net/~serb/8013586/webrev.02

Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/sound-dev/attachments/20150721/4958d0e4/attachment-0001.html>

More information about the sound-dev mailing list