<Sound Dev>  Review Request: 8013586 and 8130305
Sergey.Bylokhov at oracle.com
Tue Jul 21 15:17:01 UTC 2015
Please review the fix for jdk9. Two issues were fixed:
8013586: audioInputStream.close() does not release the resource
8130305: AudioSystem behavior depends on order that providers are located
- Streams were not closed when necessary(ex: WaveFloatFileReader.
getAudioInputStream(File)). In the fix they are closed always in case of
- Some of the readers do not reset the streams when they throw an
- Some of the readers(like AiffFileReader) do not wrap
(FileInputStream, etc) in BufferedInputStream.
In the fix I merge all implementations of getAudioXXX to the SunFileReader.
Note that I added a comment to the
SunFileReader.getAudioFileFormat(InputStream) that implementation
contradicts the specification, and it seems the javadoc should be
updated? And I created a new issue about EOFException:
Also I have a related question about WaveExtensibleFileReader why it was
not added to the spi.AudioFileReader? Because of this
WaveExtensibleFileReader actually is never used. Is that intentionally?
Webrev can be found at: http://cr.openjdk.java.net/~serb/8013586/webrev.02
Best regards, Sergey.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the sound-dev