<Sound Dev> [9] Review Request: 8143909 Behavior of null arguments not specified in javax.sound.midi.spi

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Nov 27 12:33:08 UTC 2015

Hello Audio Guru.

Please review the fix for jdk9. This issue is a subtask of:
4912693: Behavior of null arguments not specified in Java Sound

In this patch I cover the whole javax.sound.midi.spi package. And the 
patch is quite similar to the:

The small description of the fix:
- Part of the fix for JDK-8058115(integrated to jdk9 only) was reverted 
and its test was removed, because I decided to specify the NPE instead.
- I have checked all methods in the spi package and all related methods 
in MidiSystem class.
- I have moved related tests to the folder corresponding the package and 
class name.
- I have written a tests for every method and class which I changed. 
Note that these classes related to the different service providers, so I 
have covered all installed implementations of each provider.

requireNonNull in the MidiSystem is necessary only when the list of 
related providers is empty, in a general case these methods already 
throw npe.

I have done all related regression/jck/sqe tests.

Bug: https://bugs.openjdk.java.net/browse/JDK-8143909
Webrev can be found at: http://cr.openjdk.java.net/~serb/8143909/webrev.01

Best regards, Sergey.

More information about the sound-dev mailing list