<Sound Dev> [9] Review Request: 8147407 Provide support of WaveExtensible sound format

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Jan 15 02:59:04 UTC 2016

On 15/01/16 02:37, Phil Race wrote:
> The description read as  if we had some bugs in parsing but reading the
> webrev,
> if I understand correctly the problem is just that it was not listed as
> provider.


> If so, approved.


I have other review requests pending a second review, If someone will 
have some time please take a look.

> -phil.
> On 1/14/2016 3:25 PM, Sergey Bylokhov wrote:
>> Hello, Audio Guru.
>> Please review the fix for jdk9.
>> According the specification of WAV format, the WaveExtensible header
>> should be used if [1]:
>>  - PCM data has more than 16 bits/sample.
>>  - The number of channels is more than 2.
>>  - The actual number of bits/sample is not equal to the container size.
>>  - The mapping from channels to speakers needs to be specified.
>> Note that our writer contradicts the spec and writes the usual wav_pcm
>> header. But after this fix we at least will be able to read such files.
>> I am not sure should we right now change current behavior of
>> writer(for example similar issue in the sox[2]).
>> [1] http://www-mmsp.ece.mcgill.ca/documents/audioformats/wave/wave.html
>> [2] http://sourceforge.net/p/sox/bugs/88/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8147407
>> Webrev can be found at:
>> http://cr.openjdk.java.net/~serb/8147407/webrev.00

Best regards, Sergey.

More information about the sound-dev mailing list