<Sound Dev>  Review Request: 8167435 IllegalArgumentException is not thrown by Clip.open(AudioFormat, byte, int, int)
Sergey.Bylokhov at oracle.com
Mon Oct 10 17:35:04 UTC 2016
Hello, Audio Guru.
Please review the fix for jdk9.
According the specification of Clip.open(AudioFormat,byte, int, int):
* @throws IllegalArgumentException if the buffer size does not
* integral number of sample frames
void open(AudioFormat format, byte data, int offset, int bufferSize)
We have two implementations of the Clip.
- In SoftMixingClip exception is thrown
- In DirectAudioDevice exception is not thrown
DirectAudioDevice was fixed, the check was moved to the utility method.
No regressions were found by jtreg/jck tests.
Webrev can be found at: http://cr.openjdk.java.net/~serb/8167435/webrev.00
Best regards, Sergey.
More information about the sound-dev