<Sound Dev>  Review Request: 8201279 javax.sound tests should not set java.home system property
Sergey.Bylokhov at oracle.com
Sat May 5 01:03:01 UTC 2018
CSR is created:
On 21/04/2018 17:55, Sergey Bylokhov wrote:
> Hi, Roger.
> Thank you for the review.
> On 13/04/2018 07:19, Roger Riggs wrote:
>> Should the new system property javax.sound.config.file be an
>> implementation specific property
>> and named "jdk.sound.config.file"?
> This new property describe a location of the "sound.properties" file,
> which is mentioned in the public specification already. Based on this
> and on the similar property for logging I selected this name
>> Lines 99-102: The code can be simplified by using Paths instead of
>> File. Paths.get() returns a Path;
>> it can be used directly by java.nio.file.Files.newBufferedReader(Path)
>> to get the BufferedInputStream.
> The code simplified as suggested:
>> Otherwise, looks ok
>> $.02, Roger
>> Hello, Audio Guru.
>> Please review the fix for jdk11.
>> This change adds an optional "javax.sound.config.file" system
>> property(the similar name is used for logging:
>> "java.util.logging.config.file") which specified default location of the
>> properties file. Note that all errors which maybe occurs during access
>> to this file are ignored in the same way as for default config file
>> "jdk/conf/sound.properties"(BTW I am not sure that this is a good idea,
>> but follow the current approach).
>> The CSR will be filed after the technical review.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8201279
>> Webrev can be found at:
Best regards, Sergey.
More information about the sound-dev