<Sound Dev> RFR: 8211962: Implicit narrowing in MacOSX java.desktop jsound

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Oct 11 01:20:48 UTC 2018

Looks fine.

On 09/10/2018 18:23, Kim Barrett wrote:
> Please review this trivial fix of a build failure on MacOSX when
> compiling with C++11/14 enabled. An int value is being used in an
> initializer where an unsigned int is needed, which is not permitted
> since C++11.  The solution taken is to cast the value in the
> initializer.  A "better" solution would be to change the type of the
> value, but that has substantial fannout because there are many places
> in our code where signed ints were used instead of the unsigned ints
> used by the underlying MacOSX framework.
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8211962
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8211962/open.00/
> Testing:
> mach5 tier1 on MacOSX (really just verifying it builds).

Best regards, Sergey.

More information about the sound-dev mailing list