<Sound Dev> [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR)
andrewluotechnologies at outlook.com
Thu May 16 05:34:10 UTC 2019
Thanks for the review.
By the way, I am not a JDK committer, is it possible that you or someone else on this mailing list would be willing to help sponsor this change?
From: Florian Bomers <javasound-dev at bome.com>
Sent: Tuesday, May 14, 2019 2:48 AM
To: Andrew Luo <andrewluotechnologies at outlook.com>; sound-dev at openjdk.java.net
Subject: Re: <Sound Dev> [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR)
Hi, the fix looks correct to me.
On 14.05.2019 02:36, Andrew Luo wrote:
> I've been trying to get the JDK to compile with the new /permissive-
> switch in VS2017
> (https://devblogs.microsoft.com/cppblog/permissive-switch/) however
> there have been a few issues in various parts of the code. There are
> a few issues in the libjsound code where we attempt to assign string
> literals to LPSTR variables (instead of LPCSTR). I took some time to
> fix some of these and attached a patch. Let me know if you have any
> comments/feedback. I'm assuming that libjsound is owned by sound-dev,
> but if I'm mistaken, please do let me know the right team/mailing list
> to send this to.
> error C2440: 'return': cannot convert from 'const char ' to 'LPSTR'
Bome Software GmbH & Co KG Gesellschafterin:
Petra-Kelly-Str. 15 Bome Komplementär GmbH
80797 München, Germany Geschäftsführung: Florian Bömers
Amtsgericht München HRA95502 Amtsgericht München HRB185574
More information about the sound-dev