<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
@font-face
{font-family:Tunga;
panose-1:0 0 4 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Hi Phil, The version string “JDK_VERSION_STRING” is the one that was brought in as part of the implementation of the JEP: <a href="https://bugs.openjdk.java.net/browse/JDK-8085822">https://bugs.openjdk.java.net/browse/JDK-8085822</a><o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>In this they introduced a change in the name of the version string and here is that change:<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><a href="http://hg.openjdk.java.net/verona/stage/rev/4999895b3a44#l2.8">http://hg.openjdk.java.net/verona/stage/rev/4999895b3a44#l2.8</a><o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>I think it was missed out change as part of the implementation of that JEP for version string name change. I have added the same info as a confidential comment to the bug.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>I edited the file on the visual studio with just a replacing the text and I think it has inserted unnecessary indentations. I will modify that while pushing in if it is ok with you(if that’s the only change).<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Thanks and regards,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Shashi<o:p></o:p></span></p><p class=MsoNormal><a name="_MailEndCompose"><span style='color:#1F497D'><o:p> </o:p></span></a></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span style='color:windowtext'> Phil Race <br><b>Sent:</b> Friday, February 8, 2019 10:28 PM<br><b>To:</b> Shashidhara Veerabhadraiah <shashidhara.veerabhadraiah@oracle.com>; swing-dev <swing-dev@openjdk.java.net><br><b>Subject:</b> Re: <Swing Dev> [13] JDK-8190361: Incorrect version info in jaccessinspector.exe and jaccesswalker.exe<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'>So yes .. it changes that .. but could you explain why the new string is correct ?<br>I don't see an evaluation here, or in the bug report - where there should be one!<br>Also the indentation seems wrong - even when I look at the "raw" file.<br><br>-phil.<span style='font-size:12.0pt'><o:p></o:p></span></p><div><p class=MsoNormal>On 2/8/19 1:07 AM, Shashidhara Veerabhadraiah wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Hi All, Please review a fix for the below customer bug.<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8190361">https://bugs.openjdk.java.net/browse/JDK-8190361</a><o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Webrev: <a href="http://cr.openjdk.java.net/~sveerabhadra/8190361/webrev.01/">http://cr.openjdk.java.net/~sveerabhadra/8190361/webrev.01/</a><o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>The version string for the jaccessinspector and jaccesswalker modules had the string “JDK_BUILD_ID” and this change fixes that. The only doubt I had is that, hopefully these resource files are not generated from a different file and is editable by manual way.<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Thanks and regards,<o:p></o:p></p><p class=MsoNormal>Shashi<o:p></o:p></p></blockquote><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman",serif'><o:p> </o:p></span></p></div></body></html>