<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
One of the bugs covered by this fix <a
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8218469">https://bugs.openjdk.java.net/browse/JDK-8218469</a>
<br>
has had a release note (RN) attached declaring that JDK 12 won't
consider
<br>
the GTKLookAndFeel running on top of GTK+3.20 and later supported.
<br>
This RN also covers the related bugs which are also caused by
GTK+3.20 :
<br>
<br>
<a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8218470">https://bugs.openjdk.java.net/browse/JDK-8218470</a>
<br>
<a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8218472">https://bugs.openjdk.java.net/browse/JDK-8218472</a>
<br>
<a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8218473">https://bugs.openjdk.java.net/browse/JDK-8218473</a>
<br>
<a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8218479">https://bugs.openjdk.java.net/browse/JDK-8218479</a>
<br>
<br>
So we have downgraded all of these to P2, and therefore they are no
longer
<br>
candidates to fix in JDK 12 in the current RC phase per <a
class="moz-txt-link-freetext"
href="https://openjdk.java.net/jeps/3">https://openjdk.java.net/jeps/3</a>
<br>
<br>
Please push the fixes to jdk/client (ie JDK 13) instead.<br>
The existing reviews should be OK so long as the patches still apply
(eg<br>
offset changes are OK, but no rejections).<br>
<br>
-phil.
<br>
<br>
<br>
<div class="moz-cite-prefix">On 2/13/19 10:59 AM, Phil Race wrote:<br>
</div>
<blockquote type="cite"
cite="mid:107e4679-5e70-fc7c-7a21-059d93ac59ff@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
I've tested this fix on <br>
- OL 7.3 (aka RH 7.3)<br>
- OL 7.6 (aka RH 7.6)<br>
- Ubuntu 16.04<br>
- Ubuntu 18.04<br>
- Ubuntu 18.10<br>
<br>
All looks good to me.<br>
<br>
-phil.<br>
<br>
<div class="moz-cite-prefix">On 2/12/19 1:42 PM, Pankaj Bansal
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:1cc4f604-900f-440a-9c2b-55b98d50aefd@default">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered

medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi
All,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Some
more fixes are included in the patch to fix some rendering
issues with RadioButton or CheckBox in MenuItems,
RadioButton and Checkbox state flags. <o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">webrev:
<a
href="http://cr.openjdk.java.net/~pbansal/8218469/webrev01/"
moz-do-not-send="true">http://cr.openjdk.java.net/~pbansal/8218469/webrev01/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">-Pankaj<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"
moz-do-not-send="true"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1

1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:windowtext">
Pankaj Bansal <br>
<b>Sent:</b> Tuesday, February 12, 2019 11:38 PM<br>
<b>To:</b> <a class="moz-txt-link-abbreviated"
href="mailto:swing-dev@openjdk.java.net"
moz-do-not-send="true">swing-dev@openjdk.java.net</a><br>
<b>Subject:</b> <Swing Dev> [12] RFR
JDK-8218469, JDK-8218470, JDK-8218472, JDK-8203627 :
GTK3 rendering fixes for tck-red bugs<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Hi All,<o:p></o:p></p>
<p class="MsoNormal">Please review the following fix.<o:p></o:p></p>
<p class="MsoNormal"><br>
Bug: <o:p></o:p></p>
<p class="MsoNormal"><a
href="https://bugs.openjdk.java.net/browse/JDK-8218469"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8218469</a>
- JSlider display issue with slider for GTKLookAndFeel<o:p></o:p></p>
<p class="MsoNormal"><a
href="https://bugs.openjdk.java.net/browse/JDK-8218470"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8218470</a><span
style="color:windowtext"> - JScrollBar display issue with
GTKLookAndFeel</span><o:p></o:p></p>
<p class="MsoNormal"><a
href="https://bugs.openjdk.java.net/browse/JDK-8218472"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8218472</a><span
style="color:windowtext"> - JProgressBar display issue
with GTKLookAndFeel</span><o:p></o:p></p>
<p class="MsoNormal"><a
href="https://bugs.openjdk.java.net/browse/JDK-8203627"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8203627</a>
- Swing applications with JRadioButton and JCheckbox fail to
render correctly when using GTK3 and the GTK L&F <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">webrev<o:p></o:p></p>
<p class="MsoNormal"><a
href="http://cr.openjdk.java.net/~pbansal/8218469/webrev00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~pbansal/8218469/webrev00/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Issue:<o:p></o:p></p>
<p class="MsoNormal">From gtk 3.20, gtk has changed the way
themes and styles work for many widgets. Due to which, jdk
is not able to render some widgets properly including
JSlider, JProgressBar, JScrollBar, JRadioButton, JCheckbox.<o:p></o:p></p>
<p class="MsoNormal">gtk 3.20 release notes: <a
href="https://developer.gnome.org/gtk3/stable/ch32s10.html"
moz-do-not-send="true">https://developer.gnome.org/gtk3/stable/ch32s10.html</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Fix:<o:p></o:p></p>
<p class="MsoNormal">This patch fixes rendering issues in all
these widgets by using correct way to define styles. <o:p></o:p></p>
<p class="MsoNormal"><br>
Regards,<br>
Pankaj Bansal<o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:windowtext"><o:p> </o:p></span></p>
</div>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>