<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Modified webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~psadhukhan/8227607/webrev.3/">http://cr.openjdk.java.net/~psadhukhan/8227607/webrev.3/</a></p>
<p>with updated spec
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~psadhukhan/8227607/docs1/api/java.desktop/javax/swing/text/Document.html">http://cr.openjdk.java.net/~psadhukhan/8227607/docs1/api/java.desktop/javax/swing/text/Document.html</a></p>
<p>Regards</p>
<p>Prasanta<br>
</p>
<div class="moz-cite-prefix">On 09-Dec-19 11:00 PM, Philip Race
wrote:<br>
</div>
<blockquote type="cite" cite="mid:5DEE84A7.30105@oracle.com">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<ul>
<li><a
href="http://cr.openjdk.java.net/%7Epsadhukhan/8227607/docs/api/java.desktop/javax/swing/text/Document.html#putProperty%28java.lang.Object,java.lang.Object%29"
moz-do-not-send="true"><code></code></a> <br>
</li>
</ul>
<p>For more information on the <code>Document</code> class, see <a
href="http://www.oracle.com/technetwork/java/javase/tech/articles-jsp-139072.html"
moz-do-not-send="true">The Swing Connection</a> </p>
<br>
This link above seems to be obsolete as well. I think it should
just be removed<br>
<br>
>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
If an element is a a leaf,isLeaf() returns true. <br>
<br>
add a space after the comma.<br>
<br>
Also can we wrap all - or at least the ones that make sense -Â
API references in {@code ... }Â ?<br>
<br>
Method calls for sure. <br>
<br>
interrface -> interface.<br>
<br>
-phil.<br>
<br>
On 12/9/19, 3:16 AM, Prasanta Sadhukhan wrote:
<blockquote
cite="mid:0a97edf0-736b-7157-31e2-b173ba5a3729@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<p>Modified version with new subtitle ""Overview and Programming
Tips" and graphical_schema<br>
</p>
<p><a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8227607/webrev.2/">http://cr.openjdk.java.net/~psadhukhan/8227607/webrev.2/</a></p>
<p>spec change will look like <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8227607/docs/api/java.desktop/javax/swing/text/Document.html">http://cr.openjdk.java.net/~psadhukhan/8227607/docs/api/java.desktop/javax/swing/text/Document.html</a><br>
</p>
<div class="moz-cite-prefix">Regards</div>
<div class="moz-cite-prefix">Prasanta<br>
</div>
<div class="moz-cite-prefix">On 08-Dec-19 1:47 AM, Philip Race
wrote:<br>
</div>
<blockquote type="cite" cite="mid:5DEC08C4.4080200@oracle.com">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
I got very confused as to whether there was even an updated
version here.<br>
This conversation became too complex for the inline diff.<br>
I think that it would be best to first generate a webrev put
it on cr.<br>
<br>
<br>
I do think we need to have a subtitle that prefaces this new
content rather<br>
than just appending it to "Properties" ..<br>
<br>
I suggest "Overview and Programming Tips" which makes it
clearer it is not (so much) specification as developer guide.<br>
<br>
>
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
Swing has a interesting interface, called the <u><a
href="http://cr.openjdk.java.net/%7Epsadhukhan/docs/api/java.desktop/javax/swing/text/Element.html"
title="interface in javax.swing.text"
moz-do-not-send="true"><code>Element</code></a></u>,<br>
<br>
I do think this needs rephrasing. <br>
<br>
"Element is an important interface used in constructing a
Document.<br>
It has the power ...."<br>
<br>
And each time it says "In Swing" I think, why does it bother
saying that ...<br>
confusion with an SGML Element ?<br>
Maybe it would read better written as "In the Swing text API's
document model"<br>
<br>
-phil.<br>
<br>
On 12/6/19, 7:22 PM, Prasanta Sadhukhan wrote:
<blockquote
cite="mid:1ccc2a59-0025-6c51-feb2-b1f0a16ebb09@oracle.com"
type="cite">Anything more needs to be added?!!! Can it be
committed? <br>
<br>
On 06-Dec-19 9:49 AM, Prasanta Sadhukhan wrote: <br>
<blockquote type="cite">I guess I already shared... <a
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/docs/api/java.desktop/javax/swing/text/Document.html"
moz-do-not-send="true">http://cr.openjdk.java.net/~psadhukhan/docs/api/java.desktop/javax/swing/text/Document.html</a><br>
<br>
Regards <br>
<br>
Prasanta <br>
<br>
On 06-Dec-19 4:44 AM, Sergey Bylokhov wrote: <br>
<blockquote type="cite">Hi, Prasanta. <br>
<br>
Can you please share the final generated JavaDoc, it is
hard to read the diff below. <br>
<br>
On 12/4/19 10:09 am, Prasanta Sadhukhan wrote: <br>
<blockquote type="cite">Inlined information from
element_interface page into Document class <spec
will look like <a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/docs/api/java.desktop/javax/swing/text/Document.html"
moz-do-not-send="true">http://cr.openjdk.java.net/~psadhukhan/docs/api/java.desktop/javax/swing/text/Document.html</a>]<br>
<br>
/diff -r 53eff6c5da11
src/java.desktop/share/classes/javax/swing/Timer.java/
<br>
<br>
---
a/src/java.desktop/share/classes/javax/swing/Timer.java
Sun Oct 06 21:42:50 2019 -0700 <br>
+++
b/src/java.desktop/share/classes/javax/swing/Timer.java
Wed Dec 04 22:07:48 2019 +0530 <br>
@@ -124,13 +124,6 @@ <br>
  * <a href=<a class="moz-txt-link-rfc2396E"
href="https://docs.oracle.com/javase/tutorial/uiswing/misc/timer.html"
moz-do-not-send="true">"https://docs.oracle.com/javase/tutorial/uiswing/misc/timer.html"</a>
<br>
  * target = "_top">How to Use Timers</a>, <br>
  * a section in <em>The Java
Tutorial.</em> <br>
*- * For more examples and help in choosing between**
<br>
**- * this <code>Timer</code> class and**
<br>
**- * <code>java.util.Timer</code>,** <br>
**- * see** <br>
**- * <a href=<a class="moz-txt-link-rfc2396E"
href="http://java.sun.com/products/jfc/tsc/articles/timer/"
moz-do-not-send="true">"http://java.sun.com/products/jfc/tsc/articles/timer/"</a>**
<br>
**- * target="_top">Using Timers in Swing
Applications</a>,** <br>
**- * an article in <em>The Swing
Connection.</em>** <br>
*Â * <p> <br>
  * <strong>Warning:</strong> <br>
  * Serialized objects of this class will not be
compatible with <br>
<br>
/diff -r 53eff6c5da11
src/java.desktop/share/classes/javax/swing/text/Document.java/
<br>
<br>
---
a/src/java.desktop/share/classes/javax/swing/text/Document.java
Sun Oct 06 21:42:50 2019 -0700 <br>
+++
b/src/java.desktop/share/classes/javax/swing/text/Document.java
Wed Dec 04 22:07:48 2019 +0530 <br>
@@ -167,9 +167,38 @@ <br>
  * <br>
  * <p>For more information on the
<code>Document</code> class, see <br>
  * <a href=<a class="moz-txt-link-rfc2396E"
href="http://www.oracle.com/technetwork/java/javase/tech/articles-jsp-139072.html"
moz-do-not-send="true">"http://www.oracle.com/technetwork/java/javase/tech/articles-jsp-139072.html"</a>>The
Swing Connection</a> <br>
*- * and most particularly the article,** <br>
**- * <a href=<a class="moz-txt-link-rfc2396E"
href="http://java.sun.com/products/jfc/tsc/articles/text/element_interface"
moz-do-not-send="true">"http://java.sun.com/products/jfc/tsc/articles/text/element_interface"</a>>**<br>
**- * The Element Interface</a>.** <br>
**+ * <p>Swing has a interesting interface,
called the <u>{@link
javax.swing.text.Element}</u>, ** <br>
**+ * which has the power to describe various
structural parts of a document, ** <br>
**+ * such as paragraphs, lines of text, or even (in
HTML documents) items in lists. ** <br>
**+ * Conceptually, the Element interface captures
some of the spirit of an SGML document. ** <br>
**+ * So if you know SGML, you may already have some
understanding of Swing's Element interface.** <br>
**+ * <p>In Swing, the interface Element defines
a structural piece of a Document, ** <br>
**+ * like a paragraph, a line of text, or a list item
in an HTML document.** <br>
**+ * <p>Every Element is either a branch or a
leaf. If an element is a branch, ** <br>
**+ * the isLeaf() method returns false. If an element
is a a leaf,isLeaf() returns true.** <br>
**+ * <p>Branches can have any number of
children. Leaves do not have children. ** <br>
**+ * To determine how many children a branch has, you
can call getElementCount(). ** <br>
**+ * To determine the parent of an Element, you can
call getParentElement(). ** <br>
**+ * Root elements don't have parents, so calling
getParentElement() on a root returns null.** <br>
**+ * <p>An Element represents a specific region
in a Document that begins with startOffset ** <br>
**+ * and ends just before endOffset. ** <br>
**+ * The start offset of a branch Element is usually
the start offset of its first child. ** <br>
**+ * Similarly, the end offset of a branch Element is
usually the end offset of its last child.** <br>
**+ * <p>Every Element is associated with an
AttributeSet that you can access by calling
getAttributes(). ** <br>
**+ * In an Element, and AttributeSet is essentially a
set of key/value pairs. ** <br>
**+ * These pairs are generally used for markup --
such as determining the Element's ** <br>
* <br>
<br>
*+ * foreground color, font size, and so on. But it is
up to the model, and the developer, ** <br>
**+ * to determine what is stored in the
AttributeSet.** <br>
**+ * <p>You can obtain the root Element (or
Elements) of a Document by calling the ** <br>
**+ * methods getDefaultRootElement() and
getRootElements(), which are defined in the Document
interface.** <br>
**+ * <p>The Document interrface is responsible
for translating a linear view of the ** <br>
**+ * characters into Element operations. It is up to
each Document implementation ** <br>
**+ * to define what the Element structure is.** <br>
**+ * <p>It is recommended to look into {@link
javax.swing.text.EditorKit} and ** <br>
**+ * {@link javax.swing.text.View}.** <br>
**+ * View is responsible for rendering a particular
Element, and ** <br>
**+ * EditorKit is responsible for a ViewFactory that
is able to decide what ** <br>
**+ * View should be created based on an Element.* <br>
<br>
Regards <br>
<br>
Prasanta <br>
<br>
On 04-Dec-19 10:45 AM, Sergey Bylokhov wrote: <br>
<blockquote type="cite">On 12/3/19 9:08 pm, Prasanta
Sadhukhan wrote: <br>
<blockquote type="cite">Hi Sergey, <br>
<br>
I could not find the page for element_interface
itself so how to get the information from there? <br>
</blockquote>
<br>
I guess it is the same as you posted before: <br>
<a class="moz-txt-link-freetext"
href="https://web.archive.org/web/20120418045506/http://java.sun.com/products/jfc/tsc/articles/text/element_interface/"
moz-do-not-send="true">https://web.archive.org/web/20120418045506/http://java.sun.com/products/jfc/tsc/articles/text/element_interface/</a>
<br>
<br>
<blockquote type="cite"> <br>
Regards <br>
<br>
Prasanta <br>
<br>
On 04-Dec-19 7:31 AM, Sergey Bylokhov wrote: <br>
<blockquote type="cite">Hi, Prasanta. <br>
Probably we can inline some information from the
element_interface.html to the JavaDoc itself?
The JavaDoc already has some similar schemes. <br>
<br>
On 12/2/19 2:37 am, Prasanta Sadhukhan wrote: <br>
<blockquote type="cite">Hi All, <br>
<br>
Please review a doc-fix for removing some dead
links from the specifications. These links
were part of java.sun.com but has not been
migrated to docs.oracle.com so it's better to
remove them <br>
<br>
Bug: <a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8227607"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8227607</a>
<br>
<br>
diff -r 7637e77c4c8a
src/java.desktop/share/classes/javax/swing/Timer.java
<br>
---
a/src/java.desktop/share/classes/javax/swing/Timer.java
Mon Dec 02 11:58:14 2019 +0530 <br>
+++
b/src/java.desktop/share/classes/javax/swing/Timer.java
Mon Dec 02 16:02:08 2019 +0530 <br>
@@ -124,13 +124,6 @@ <br>
  * <a href=<a
class="moz-txt-link-rfc2396E"
href="https://docs.oracle.com/javase/tutorial/uiswing/misc/timer.html"
moz-do-not-send="true">"https://docs.oracle.com/javase/tutorial/uiswing/misc/timer.html"</a>
<br>
  * target = "_top">How to Use
Timers</a>, <br>
  * a section in <em>The Java
Tutorial.</em> <br>
*- * For more examples and help in choosing
between** <br>
**- * this <code>Timer</code>
class and** <br>
**- *
<code>java.util.Timer</code>,** <br>
**- * see** <br>
**- * <a href=<a
class="moz-txt-link-rfc2396E"
href="http://java.sun.com/products/jfc/tsc/articles/timer/"
moz-do-not-send="true">"http://java.sun.com/products/jfc/tsc/articles/timer/"</a>**
<br>
**- * target="_top">Using Timers in Swing
Applications</a>,** <br>
**- * an article in <em>The Swing
Connection.</em>* <br>
  * <p> <br>
  * <strong>Warning:</strong> <br>
  * Serialized objects of this class will not
be compatible with <br>
diff -r 7637e77c4c8a
src/java.desktop/share/classes/javax/swing/text/Document.java
<br>
---
a/src/java.desktop/share/classes/javax/swing/text/Document.java
Mon Dec 02 11:58:14 2019 +0530 <br>
+++
b/src/java.desktop/share/classes/javax/swing/text/Document.java
Mon Dec 02 16:02:08 2019 +0530 <br>
@@ -167,9 +167,6 @@ <br>
  * <br>
  * <p>For more information on the
<code>Document</code> class, see <br>
  * <a href=<a
class="moz-txt-link-rfc2396E"
href="http://www.oracle.com/technetwork/java/javase/tech/articles-jsp-139072.html"
moz-do-not-send="true">"http://www.oracle.com/technetwork/java/javase/tech/articles-jsp-139072.html"</a>>The
Swing Connection</a> <br>
*- * and most particularly the article,** <br>
**- * <a href=<a
class="moz-txt-link-rfc2396E"
href="http://java.sun.com/products/jfc/tsc/articles/text/element_interface"
moz-do-not-send="true">"http://java.sun.com/products/jfc/tsc/articles/text/element_interface"</a>>**<br>
**- * The Element Interface</a>.* <br>
  * <br>
  * @author Timothy Prinzing <br>
<br>
<br>
Regards <br>
<br>
Prasanta <br>
<br>
</blockquote>
<br>
<br>
</blockquote>
</blockquote>
<br>
<br>
</blockquote>
</blockquote>
<br>
<br>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>