type-annotations test failures: update

Werner Dietl wdietl at gmail.com
Thu Apr 11 01:26:03 PDT 2013


On Wed, Apr 10, 2013 at 6:39 PM, Jonathan Gibbons
<jonathan.gibbons at oracle.com> wrote:
> OK, after making allowances for some pilot error earlier today, and after
> fixing up problems with diagnostics, I've reduced the test of test failures

thanks for your fixes and added test cases!

> to these:
> Failed. com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java
> Failed. com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java
> Bhavesh says the first is fixed in his webrev which he is waiting to push,
> so I can see us overlooking these for now. (We need to break a circular
> dependency, here.)

Great! Could we push Bhavesh's changes into the type-annotations repo
to test them?

> Failed. tools/javac/annotations/typeAnnotations/classfile/T8008762.java

Please see this message:


and my exchange with Steve earlier this week. I think both issues are
related and an answer to that email would be appreciated.

> tools/javac/annotations/typeAnnotations/classfile/T8008769.java
> tools/javac/annotations/typeAnnotations/classfile/TestNewCastArray.java

These two are about repeated type annotations and Joel will look at them.
Steve also disabled a few other tests related to repeated type
annotations that we should enable eventually.

> tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java

I've been working on this one over the past several days and just pushed my fix:


and a few earlier changesets.
Please have a look through this change, in particular the places
marked as "TODO" or "review".
I think this works as desired now, but somebody should look through my
examples and extend them with code that creates crazier exception
Also, I changed things I didn't have to touch before - e.g. Pool - and
somebody should review them.
On the bright side, the Checker Framework still works with these changes.

> tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java

This is the next one on my TODO list.
After this, I will look at the bug-report from Steve earlier this week
about nested classes in throws.
Finally, I'll do the method/constructor receiver cleanups suggested by
you and check that all of Alex's descriptions are implemented.

> I'm assuming these are serious and need to be fixed.
> Failed. tools/javac/lambda/SerializedLambdaInInit.java
> Error.  tools/javac/lambda/TargetType24.java
> I'm prepared to overlook these for now, although I'll also check if these
> are also failing in tl. I don't think they are.

I haven't looked at test cases outside of javac recently and wouldn't
really know how I've broken those two.
I'll have a look.

> Failed. tools/javac/processing/model/type/BasicAnnoTests.java
> I wrote this test and pushed it into type-annotations because it seemed
> to demo a problem with the support for the javax.lang.model API.
> Someone needs to look at it.

I can have a quick look at this test case, I haven't seen it yet. I'll
come back with questions.

Is there any particular deadline for which we should aim for TL integration?

cu, WMD.


More information about the type-annotations-dev mailing list