type-annotations based on JDK 9?

Alex Buckley alex.buckley at oracle.com
Thu Jan 16 12:46:02 PST 2014


Am I right in saying that the changes that Werner identifies as being 
solely in type-annotations/langtools can be applied to jdk8u/langtools 
right now?

Or are we at the point when they have to go into jdk9/dev/langtools 
first, then be backported to jdk8u?


I don't know your plans, but if you expect to be contributing to javac 
in the future, then becoming a Committer in JDK 8 Updates or JDK 9 would 
be the right thing to do.


On 1/15/2014 12:18 PM, Werner Dietl wrote:
> In preparation for moth-balling the type-annotations repositories,
> I've just synced type-annotations against jdk9/dev.
> All repositories other than "langtools" are equal (except for .hgtags
> files and the jdk repo, where I pulled a few additional jdk8 changes
> that are not in jdk9 yet). There is not a lot of interesting history
> in these repos.
> I made type-annotations/langtools as similar to jdk9/dev/langtools as possible.
> The last remaining differences, which I think at some point should
> move to jdk9/dev, are:
> src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java
>      Instantiates an Options object that is not needed.
> src/share/classes/com/sun/tools/javac/comp/Check.java
>      Contains a checkNonNull call that results in generating a String
> for an annotation - potentially expensive.
> src/share/classes/com/sun/tools/javac/model/JavacTypes.java
>      Improved an exception message.
> src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java
>      Fix a typo in a doc-comment.
> src/share/classes/com/sun/tools/javac/parser/Scanner.java
> src/share/classes/javax/annotation/processing/Messager.java
> src/share/classes/javax/lang/model/element/Element.java
> src/share/classes/javax/lang/model/type/TypeMirror.java
> src/share/classes/javax/lang/model/type/TypeVariable.java
> src/share/classes/javax/lang/model/type/TypeVisitor.java
> src/share/classes/javax/lang/model/util/Elements.java
> src/share/classes/javax/lang/model/util/Types.java
> src/share/classes/javax/tools/JavaCompiler.java
> src/share/classes/javax/tools/SimpleJavaFileObject.java
> src/share/classes/javax/tools/StandardJavaFileManager.java
>      Clean up imports. Most changes remove unused imports.
> test/tools/javac/annotations/typeAnnotations/classfile/T8008762.java
>      Fix whitespace.
> test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java
> test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.out
> test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.java
> test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass3.java
> test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass3.out
>      These tests work for me. Is there a reason to ignore them?
> test/tools/javac/annotations/typeAnnotations/referenceinfos/Enums.java
>      This is the last test failure assigned to me.
> test/tools/javac/lib/DPrinter.java
>      Does the jdk9/dev version of this file compile?
> test/tools/javac/processing/model/type/BasicAnnoTests.java
>      This is a failing test. I extended it with a few more cases.
>> Since you were an Author in the JDK 8 Project, you're an Author in the JDK 8
>> Updates Project and JDK 9 Project. It would probably be useful for you to be
>> a Committer in one or both of those Projects, but there's a process for
>> that, of course.
> I am very thankful that Jon took care of these administrative issues for me.
> I'm open to apply for the Committer role, but maybe that's not
> necessary for the few remaining patches from me.
> Let me know which way you prefer.
> cu, WMD.

More information about the type-annotations-dev mailing list