C2: No need to allocate value types for uncommon trap's debug info

Tobias Hartmann tobias.hartmann at oracle.com
Wed Dec 14 08:37:48 UTC 2016


Hi Roland,

On 14.12.2016 09:13, Roland Westrelin wrote:
> 
> Hi Tobias,
> 
>>> http://cr.openjdk.java.net/~roland/valhalla/noallocatunc/webrev.00/
>>
>> Why is that code not needed anymore?
> 
>   case Op_ValueType: {
>     ValueTypeNode* vt = n->as_ValueType();
>     vt->make_scalar_in_safepoints(this);
>     if (vt->outcnt() == 0) {
>       vt->disconnect_inputs(NULL, this);
>     }
>     break;
>   }
> 
> in Compile::final_graph_reshaping() should change the debug info of the
> uncommon traps so it doesn't include any value types or am I missing
> something?

Right, I thought this was still required because you mentioned this in the RFR for your SafePointNodes change [1]. But with flattened value type support, this is not longer needed.

Looks good!

Thanks,
Tobias

[1] http://mail.openjdk.java.net/pipermail/valhalla-dev/2016-November/002063.html


More information about the valhalla-dev mailing list