RFR: initial set of tests for nestmates vm exploration

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Tue Feb 16 10:39:15 UTC 2016


Looks good; I found few typos i.e. PPRIVATE and pprivate (is that 
deliberate?).

Also, on a more substantial point, these are all positive tests; would 
it make sense to have also some negative tests to verify that:

* you can't get access outside nestmate boundaries (perhaps hard to 
write/compile with javac, but should be doable with reflection)
* private members are not accidentally inherited (again, hard to 
write/compile with javac)

Maurizio

On 16/02/16 08:01, Stas Smirnov wrote:
> Hello,
>
> Please review this initial set of tests for nestmates vm exploration. 
> This new tests cover basic runtime access checks in down->up direction 
> in terms of nested classes and inheritance. There are going to be more 
> tests to speedup runtime development of nestmates support.
>
> webrev.00: http://cr.openjdk.java.net/~stsmirno/nestmates/webrev.00
> Testing: RBT
>



More information about the valhalla-dev mailing list