Initial RFR: 8187302: [Nestmates] Prepare for classfile version 54 and javac "release" update

David Holmes david.holmes at oracle.com
Thu Sep 7 22:18:11 UTC 2017


On 8/09/2017 8:14 AM, forax at univ-mlv.fr wrote:
> ----- Mail original -----
>> De: "David Holmes" <david.holmes at oracle.com>
>> À: "Remi Forax" <forax at univ-mlv.fr>
>> Cc: "valhalla-dev" <valhalla-dev at openjdk.java.net>
>> Envoyé: Jeudi 7 Septembre 2017 12:48:00
>> Objet: Re: Initial RFR: 8187302: [Nestmates] Prepare for classfile version 54 and javac "release" update
> 
>> Hi Remi,
>>
>> On 7/09/2017 7:39 PM, Remi Forax wrote:
>>> Hi David,
>>> Having 10 -> v53 and 11 -> v54 is weird,
>>
>> How is that weird? I just incremented the value. If it turns out that 10
>> needs to bump to 54 then I'd bump 11 to 55.
>>
>>> perhaps, --release 99 is better than release 11.
>>
>> ???
> 
> Reading your patch, for me it was like you wanted something more like version_max hence '99', 99 being v54 currently.

Do you mean the asm changes? I introduced V_MAX purely to avoid the need 
to edit ClassReader.java whenever the version increased.

David

>>
>> David
> 
> Rémi
> 
>>
>>> Rémi
>>>
>>> ----- Mail original -----
>>>> De: "David Holmes" <david.holmes at oracle.com>
>>>> À: "valhalla-dev" <valhalla-dev at openjdk.java.net>
>>>> Envoyé: Jeudi 7 Septembre 2017 10:54:04
>>>> Objet: Initial RFR: 8187302: [Nestmates] Prepare for classfile version 54 and
>>>> javac "release" update
>>>
>>>> webrev: http://cr.openjdk.java.net/~dholmes/8187302/webrev/
>>>>
>>>> (please ignore the two hotspot test changes)
>>>>
>>>> This changes prepares for switching to release 11 and classfile version
>>>> 54 so that I can put classfile version checks where needed, and compile
>>>> tests the right way, where needed.
>>>>
>>>> Initially the default remains release 10 and v53, but --release 11 can
>>>> be used to explicitly use v54.
>>>>
>>>> I think I have found everything that needs updating to allow use of
>>>> release 11 and v54 classfiles.
>>>>
>>>> Testing so far is minimal: javac Foo.java -> v53
>>>>                              javac --release 11 Foo.java -> v54
>>>>
>>>> langtools/tools/javac testing also conducted.
>>>>
>>>> Thanks,
>>>> David


More information about the valhalla-dev mailing list