[Nestmates] RFR: 8187360) [Nestmates] Remove invokespecial changes

David Holmes david.holmes at oracle.com
Mon Sep 11 11:40:29 UTC 2017


Thanks Maurizio!

David

On 11/09/2017 6:26 PM, Maurizio Cimadamore wrote:
> Looks good
> 
> Maurizio
> 
> 
> On 11/09/17 03:15, David Holmes wrote:
>> On 8/09/2017 4:20 PM, David Holmes wrote:
>>> webrev: http://cr.openjdk.java.net/~dholmes/8187360/webrev/
>>
>> I was asked for a webrev showing diffs to jdk10/hs code to confirm 
>> things were reverted correctly:
>>
>> http://cr.openjdk.java.net/~dholmes/8187360/webrev.jdk10/
>>
>> The changes to verifier.cpp are indentation only.
>>
>> Thanks,
>> David
>>
>>> The initial proposal was extending the use of invokespecial to allow 
>>> it to be used for private nestmate method invocations. To support 
>>> that changes had to be made to the verifier. After JVMLS it was 
>>> decided that we would use invokevirtual and invokeinterface (as 
>>> appropriate) as the specification changes needed are much simpler. 
>>> The switch to that approach was done under JDK-8187221 and 
>>> JDK-8186763. Now we can remove the invokespecial changes that were 
>>> initially put in place.
>>>
>>> Thanks,
>>> David
>>>
> 


More information about the valhalla-dev mailing list