RFR (S): [MVT] Ensure JVMS spec rules for creation and loading of DVT are followed

Frederic Parain frederic.parain at oracle.com
Tue Sep 12 17:37:59 UTC 2017


Looks good to me.

Minor point:
src/share/vm/runtime/fieldType.cpp:

   77 static const char dvt_postfix[] = "$Value";
   78 static const int dvt_postfix_len = 6;

Could we have an assert somewhere checking that dvt_postfix_len
matches the dvt_postfix string? Just in case someone update the
string without changing the len.

Fred


On 09/12/2017 05:38 AM, David Simms wrote:
> Greetings,
> 
> Here's a patch containing further testing, and fix for MVT loading of VM 
> derived value type class, even before touching its Value Capable Class. 
> Throws correct exception according to draft spec (ICCE when VCC rules 
> broken etc, http://cr.openjdk.java.net/~dlsmith/values.html#values-5.3)
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8184919
> 
> Webrev: http://cr.openjdk.java.net/~dsimms/valhalla/8184919/webrev0/
> 
> 
> Cheers
> 
> /David Simms
> 


More information about the valhalla-dev mailing list