[Nestmates] RFR: 8187360) [Nestmates] Remove invokespecial changes

David Holmes david.holmes at oracle.com
Thu Sep 14 04:52:46 UTC 2017


On 14/09/2017 12:15 PM, Karen Kinnear wrote:
> Would it work for you to make a single webrev from the current state of your nest mate repo relative
> to the parent? I am trying to review relative to the spec and found this changeset and the last one, but
> not the one before.

Sorry Karen but I don't seem to be able to do that. For whatever reason 
"webrev -r default" shows me only changes that are not the nestmate 
ones. ?? (Have I mentioned that I loath working with branches :( )

I added changeset links to all of the bugs for which I've pushed changes.

David

> That would it make it much easier for me to review all together.
> 
> thanks very much,
> Karen
> 
>> On Sep 10, 2017, at 10:15 PM, David Holmes <david.holmes at oracle.com> wrote:
>>
>> On 8/09/2017 4:20 PM, David Holmes wrote:
>>> webrev: http://cr.openjdk.java.net/~dholmes/8187360/webrev/
>>
>> I was asked for a webrev showing diffs to jdk10/hs code to confirm things were reverted correctly:
>>
>> http://cr.openjdk.java.net/~dholmes/8187360/webrev.jdk10/
>>
>> The changes to verifier.cpp are indentation only.
>>
>> Thanks,
>> David
>>
>>> The initial proposal was extending the use of invokespecial to allow it to be used for private nestmate method invocations. To support that changes had to be made to the verifier. After JVMLS it was decided that we would use invokevirtual and invokeinterface (as appropriate) as the specification changes needed are much simpler. The switch to that approach was done under JDK-8187221 and JDK-8186763. Now we can remove the invokespecial changes that were initially put in place.
>>> Thanks,
>>> David
> 


More information about the valhalla-dev mailing list