Review Request: JDK-8186874: [MVT] Method name generated by ValueType is illegal

mandy chung mandy.chung at oracle.com
Wed Sep 20 05:14:02 UTC 2017


Thanks for the review, Maurizio.

Tobias - I have pushed the change without the 
hotspot/test/compiler/valhalla test update.  I leave it for you to push 
for JDK-8187670.

Mandy

On 9/19/17 4:46 PM, Maurizio Cimadamore wrote:
> Looks great - thanks!
>
> Maurizio
>
>
> On 20/09/17 00:26, mandy chung wrote:
>> Webrev:
>> http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8186874/webrev.00/
>>
>> This patch fixes the bytecode generation with a legal method name.  I 
>> test with the runtime/valuetypes and compiler/valuetypes tests with 
>> -noverify flag removed except ValueOops.java and VboxUnbox.java 
>> tests. ValueOops.java and VboxUnbox.java tests fail with a different 
>> error when verifier is enabled.  I'll look into JDK-8187696 separately.
>>
>> Tobias - the webrev includes your patch for JDK-8187670 to verify my 
>> fix.  Do you prefer to leave it for you to push separately?  Or I can 
>> push it for you?
>>
>> thanks
>> Mandy
>



More information about the valhalla-dev mailing list