Review Request: JDK-8186874: [MVT] Method name generated by ValueType is illegal
tobias.hartmann at oracle.com
Wed Sep 20 06:34:59 UTC 2017
On 20.09.2017 07:14, mandy chung wrote:
> Tobias - I have pushed the change without the hotspot/test/compiler/valhalla test update. I leave it for you to push
> for JDK-8187670.
Perfect, thanks a lot for fixing this so quickly!
> On 9/19/17 4:46 PM, Maurizio Cimadamore wrote:
>> Looks great - thanks!
>> On 20/09/17 00:26, mandy chung wrote:
>>> This patch fixes the bytecode generation with a legal method name. I test with the runtime/valuetypes and
>>> compiler/valuetypes tests with -noverify flag removed except ValueOops.java and VboxUnbox.java tests. ValueOops.java
>>> and VboxUnbox.java tests fail with a different error when verifier is enabled. I'll look into JDK-8187696 separately.
>>> Tobias - the webrev includes your patch for JDK-8187670 to verify my fix. Do you prefer to leave it for you to push
>>> separately? Or I can push it for you?
More information about the valhalla-dev