hg: valhalla/valhalla: Initial support for code generation using defaultvalue and withfield

Frederic Parain frederic.parain at oracle.com
Thu Feb 8 14:41:46 UTC 2018


Remi,

I understand the pain of maintaining ASM in sync with a moving
target like the Valhalla project. We could revert the mapping
of these opcodes, but it won't allow people to use an old version
of ASM to work with the L-world prototype because there's more
changes than just the bytecodes mapping. For instance, some flags
have been changed, and are now required where they were previously
not required.

Fred

On 02/07/2018 04:24 AM, Remi Forax wrote:
> It's just a question, if it means more work from your side, it doesn't worth it.
> 
> Remi
> 
> 
> On February 6, 2018 9:55:30 PM UTC, Srikanth <srikanth.adayapalam at oracle.com> wrote:
>> Hi Rémi,
>>
>> I am happy to do this. The code was leveraged as is from the existing
>> VaIhalla prototype.
>>
>> However, I will wait until early next week for any dissenting opinions
>> to be heard to make sure no nuances are overlooked (Frederic ?)
>>
>> Srikanth
>>
>> On Tuesday 06 February 2018 07:51 PM, Remi Forax wrote:
>>> Thanks Srikanth,
>>> i've seen that defaultvalue and withfield are now mapped to opcode
>> 203 and 204,
>>> can we keep them mapped to 208 and 209 (temporarily) as in the
>> previous prototype so people will be to reuse the same version of ASM,
>>> or maybe the semantics is/will different ?
>>>
>>> Rémi
>>>
>>> ----- Mail original -----
>>>> De: "Srikanth" <srikanth.adayapalam at oracle.com>
>>>> À: "valhalla-dev" <valhalla-dev at openjdk.java.net>
>>>> Envoyé: Mardi 6 Février 2018 13:47:41
>>>> Objet: hg: valhalla/valhalla: Initial support for code generation
>> using defaultvalue and withfield
>>>> Changeset: 4dc46c132c2e
>>>> Author:    sadayapalam
>>>> Date:      2018-02-06 18:13 +0530
>>>> URL:
>> http://hg.openjdk.java.net/valhalla/valhalla/rev/4dc46c132c2e
>>>>
>>>> Initial support for code generation using defaultvalue and withfield
>>>>
>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java
>>>> !
>> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ByteCodes.java
>>>> !
>> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java
>>>> !
>> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Code.java
>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java
>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Items.java
>>>> ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/Opcode.java
>>>> + test/langtools/tools/javac/valhalla/lworld-values/CheckFlags.java
>>>> +
>> test/langtools/tools/javac/valhalla/lworld-values/ValueCreationTest.java
> 


More information about the valhalla-dev mailing list