[Nestmates] RFR: 8197539: [Nestmates] Revert all changes to VerifyAccess.isSameMemberPackage and Lookup.in behaviour

mandy chung mandy.chung at oracle.com
Tue Feb 13 22:02:00 UTC 2018



On 2/13/18 1:50 PM, David Holmes wrote:
>
> I would prefer to leave unmodified code completely unmodified to 
> simplify the eventual code review when pushing to mainline. While such 
> a comment may seem useful due to the way this issue arose, if we back 
> up and view this as never-changed code, then commenting that it 
> doesn't need to change seems unnecessary to me. There are numerous 
> things that work unchanged with nestmates (specifically anything to do 
> with inner classes attributes and existing enclosing class notions), 
> and we won't want to add comments to them all.

I will leave it up to you.   I see such clarification might help and I 
can't see how a comment might complicate the code review.

Mandy


More information about the valhalla-dev mailing list