RFR: 8229372: Static inline fields should allow circularity.

Frederic Parain frederic.parain at oracle.com
Wed Aug 14 19:16:22 UTC 2019

Thank you for the review.


> On Aug 14, 2019, at 08:59, David Simms <david.simms at oracle.com> wrote:
> All in all it looks good...
> I did need to re-read the code back (a second time) from src/hotspot/share/interpreter/interpreterRuntime.cpp:400, the point was the CHECK macros as per the intro comment should throw and the fatal not be reached. fatal() message says this.
> Cheer, thanks for the fix Frederic !
> On 2019-08-13 21:42, Frederic Parain wrote:
>> Greeting,
>> Here’s a changeset to relax the circularity rules
>> for static fields.
>> The handling of erroneous situations is not great,
>> but relaxing rules could allow explorations at
>> the language level. Error handling would have to
>> be fixed later (it requires to store the error on
>> first initialization failure, in order to throw exactly
>> the same error on further attempts to initialize the field).
>> CR: https://bugs.openjdk.java.net/browse/JDK-8229372
>> Webrev: http://cr.openjdk.java.net/~fparain/statics2/webrev.00/index.html
>> Thank you,
>> Fred

More information about the valhalla-dev mailing list