RFR 8223349: [lworld] Reflection support on static <init> factory methods for inline types

Roger Riggs Roger.Riggs at oracle.com
Mon Jun 3 18:44:09 UTC 2019


Hi Mandy,

New webrev:

http://cr.openjdk.java.net/~rriggs/webrev-init-8223349-6/index.html

On 05/31/2019 04:23 PM, Mandy Chung wrote:
>
>
> On 5/31/19 12:13 PM, Roger Riggs wrote:
>> Hi,
>>
>> A minor update to make the test code checking constructors more 
>> generic and used for
>> Point, Line, and NonFlattenedValue.  It only checked the signatures, 
>> but does not invoke each constructor.
>>
>> webrev:
>> http://cr.openjdk.java.net/~rriggs/webrev-init-8223349-4/index.html
>>
>
> AccessibleObject.checkCanSetAccessible also needs update as it special 
> case the Constructor case of a inline class which is no longer 
> needed.  It will follow normal access check rule.
Removed:  (Since it did not throw an exception when requested, it may 
have been silently ignored)
>
> For the test, constructors take the expected toString names.   I 
> suggest to create a local inline class to have the expected 
> constructors.  Also move ctor.setAccessible and ctor.trySetAccessible 
> to use this new inline class as these test cases are specific to 
> static init factories.  Maybe time to have a separate test file for 
> static init factories rather than extending the existing test.
Moved tests for constructors of inline classes and setAccessible tests 
to InlineConstructorTest.java.

Thanks, Roger

>
> thanks
> Mandy



More information about the valhalla-dev mailing list