RFR (S) 8217714: [lworld] Support for substitutability checks in interpreter

David Simms david.simms at oracle.com
Wed Jun 5 13:47:40 UTC 2019


Adjustments made.

Thank you Frederic !

On 2019-06-05 14:22, Frederic Parain wrote:
> templateTable_x86.cpp: 2478:
>    - a more explicit comment explaining that the test below checks if any of the
>      two arguments is null would make the code easier to understand
>
> interpreterRuntime.cpp: 529:
>
> Instead of
>
> 529   if (HAS_PENDING_EXCEPTION) {
>   530     fatal("isSubstitutable() raised exception");
>   531   }
>
> I would prefer
>
>    guarantee(!HAS_PENDING_EXCEPTION,"isSubstitutable() raised exception”);
>
> Are we sure that the substitutability test will never, ever throw an exception?


Nope, if it does throw an exception, we have a problem, I'd rather not 
quietly swallow the exception


>
> Otherwise, the changeset looks good. Thumbs up! (no need for another review).
>
> Thank you for fixing the substitutability code in the interpreter.
>
> Fred
>
>
>> On May 27, 2019, at 10:58, David Simms <david.simms at oracle.com> wrote:
>>
>>
>> Nice, thanks, updated, fix stray formatting, dropped test change
>>
>> On 27/05/19 4:07 PM, Tobias Hartmann wrote:
>>> Hi Mr. Simms,
>>>
>>> On 27.05.19 10:17, David Simms wrote:
>>>>       o Found an issue with "TestLWorld", adjust it to continue with
>>>>         mode 2, (bug filed for mode 3, JDK-8224818).
>>> I've fixed this test bug:
>>> http://hg.openjdk.java.net/valhalla/valhalla/rev/fa2c82a95f82
>>>
>>> You can therefore remove the adjustment to run with mode 2.
>>>
>>> Best regards,
>>> Tobias
>>


More information about the valhalla-dev mailing list