RFR 8218619 [lworld] Execute all test scenarios with C1

Tobias Hartmann tobias.hartmann at oracle.com
Thu Jun 6 11:48:44 UTC 2019


Hi Ioi,

this looks good to me.

Best regards,
Tobias

On 06.06.19 00:43, Ioi Lam wrote:
> https://bugs.openjdk.java.net/browse/JDK-8218619
> http://cr.openjdk.java.net/~iklam/valhalla/8218619-execute-all-test-scenarios-with-c1.v01/
> 
> When testing C1, we used to just test the 1st of 6 possible scenarios [1]. With this patch,
> all 6 scenarios are executed, and I've found a few more bugs in C1's handling of value types.
> 
> What's changed:
> 
> + Fixed 2 simple C1 bugs in this patch.
>     - I filed a few bugs to track the other failures
> 
> + Added a new @TempSkipForC1 to skip some test cases that are known
>   to fail with C1.
> 
> + I also fixed TestOnStackReplacement.java to terminate
>   when the test method is OSR-compiled. This significantly
>   speeds up the test.
> 
> 
> Testing -- all tests passed with:
> 
>     jtreg -vmoptions:-XX:+EnableValhallaC1 -vmoptions:-XX:TieredStopAtLevel=1 .
> 
> 
> Notes:
> 
> [1]
> http://hg.openjdk.java.net/valhalla/valhalla/file/bd2896e93b2c/test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java#l199
> 
> 
> 
> Thanks
> - Ioi


More information about the valhalla-dev mailing list