RFR(L) Valhalla support for AArch64 v.05
stuart.monteith at linaro.org
Thu Jun 27 09:20:24 UTC 2019
I've just had a quick glance over the code, I'm not familiar with valhalla.
test/hotspot/jtreg/compiler/valhalla/valuetypes/TestArrays.java, et. al.
- * @requires os.simpleArch == "x64"
By removing the restriction on x64 only, are you not opening up the
tests to all platforms? Should it just be for x64 and aarch64 until
the other platforms are added?
// DMS CHECK: the code is significantly differ from x86
// DMS CHECK: is it nop?
// DMS CHECK: This code should be fixed in JDK workspace, because
Did you mean to leave in your "DMS CHECK" comments here (and elsewhere)?
// DMS CHECK: 8210498: nmethod entry barriers is not implemented
I'm currently looking at concurrent class unloading for ZGC - I will
also need nmethod entry barriers. I'll let you know how I'm getting on
On Thu, 27 Jun 2019 at 08:53, Dmitry Samersoff <dms at samersoff.net> wrote:
> Hello Everybody,
> Please review v.05 of adding AArch64 support to lworld branch
> What was done:
> Implemented Valhalla support for aarch64.
> Support for ValueTypePassFieldsAsArgs and ValueTypeReturnedAsFields
> is not completed and is not included into this webrev
> to reduce review and rebasing efforts.
> All tests in runtime/valhalla/valuetypes and in
> compiler/valhalla/valuetypes/ are passed
> are passed after manually tweaking of output patterns, I have not
> found a way to support both x86 and aarch64, so these tests remain
> unchanged and run on x64 only.
More information about the valhalla-dev