RFR(L) Valhalla support for AArch64 v.05

Ioi Lam ioi.lam at oracle.com
Thu Jun 27 16:09:44 UTC 2019


Hi Dmitry,

During the port, have you found anything that should be refactored and
put into shared code?

One thing that I am thinking of doing is to refactor the code in
macroAssembler_x86.cpp that deals with ValueTypePassFieldsAsArgs.
Hopefully that will make the port to other architectures easier.

Thanks
- Ioi


On 6/27/19 12:43 AM, Dmitry Samersoff wrote:
> Hello Everybody,
>
>
> Please review v.05 of adding AArch64 support to lworld branch
>
> http://cr.openjdk.java.net/~dsamersoff/valhalla_lworld_aarch64/webrev.05/
>
> What was done:
>
>    Implemented Valhalla support for aarch64.
>
>    Support for ValueTypePassFieldsAsArgs and ValueTypeReturnedAsFields
>    is not completed and is not included into this webrev
>    to reduce review and rebasing efforts.
>
> Testing:
>
>     All tests in runtime/valhalla/valuetypes and in
> compiler/valhalla/valuetypes/ are passed
>
>     compiler/valhalla/valuetypes/TestMethodHandles.java
>     compiler/valhalla/valuetypes/TestBasicFunctionality.java
>
>     are passed after manually tweaking of output patterns, I have not
> found a way to support both x86 and aarch64, so these tests remain
> unchanged and run on x64 only.
>
>
> -Dmitry



More information about the valhalla-dev mailing list