RFR(L) Valhalla support for AArch64 v.05
dms at samersoff.net
Thu Jun 27 16:34:33 UTC 2019
I agree with you about value type pack/unpack logic.
I'm not sure that it's possible to put it to shared code completely, but
at least we can consider moving the entire pack/unpack logic into a
separate function and re-use it rather than duplicate code.
Anther (not-technical) thing, that simplify porting is mark CR, which
touches platform-specific code, with some specific label.
Another (process) thing that can simplify porting is the CR tag, which
concerns the platform-specific code, a specific label.
On 27.06.19 19:09, Ioi Lam wrote:
> Hi Dmitry,
> During the port, have you found anything that should be refactored and
> put into shared code?
> One thing that I am thinking of doing is to refactor the code in
> macroAssembler_x86.cpp that deals with ValueTypePassFieldsAsArgs.
> Hopefully that will make the port to other architectures easier.
> - Ioi
> On 6/27/19 12:43 AM, Dmitry Samersoff wrote:
>> Hello Everybody,
>> Please review v.05 of adding AArch64 support to lworld branch
>> What was done:
>> Implemented Valhalla support for aarch64.
>> Support for ValueTypePassFieldsAsArgs and ValueTypeReturnedAsFields
>> is not completed and is not included into this webrev
>> to reduce review and rebasing efforts.
>> All tests in runtime/valhalla/valuetypes and in
>> compiler/valhalla/valuetypes/ are passed
>> are passed after manually tweaking of output patterns, I have not
>> found a way to support both x86 and aarch64, so these tests remain
>> unchanged and run on x64 only.
More information about the valhalla-dev